mod fixtures; use assert_fs::fixture::TempDir; use fixtures::{server, server_no_stderr, tmpdir, Error, TestServer}; use reqwest::blocking::{multipart, Client}; use rstest::rstest; use select::document::Document; use select::predicate::{Attr, Text}; #[rstest] fn uploading_files_works(#[with(&["-u"])] server: TestServer) -> Result<(), Error> { let test_file_name = "uploaded test file.txt"; // Before uploading, check whether the uploaded file does not yet exist. let body = reqwest::blocking::get(server.url())?.error_for_status()?; let parsed = Document::from_read(body)?; assert!(parsed.find(Text).all(|x| x.text() != test_file_name)); // Perform the actual upload. let upload_action = parsed .find(Attr("id", "file_submit")) .next() .expect("Couldn't find element with id=file_submit") .attr("action") .expect("Upload form doesn't have action attribute"); let form = multipart::Form::new(); let part = multipart::Part::text("this should be uploaded") .file_name(test_file_name) .mime_str("text/plain")?; let form = form.part("file_to_upload", part); let client = Client::new(); client .post(server.url().join(upload_action)?) .multipart(form) .send()? .error_for_status()?; // After uploading, check whether the uploaded file is now getting listed. let body = reqwest::blocking::get(server.url())?; let parsed = Document::from_read(body)?; assert!(parsed.find(Text).any(|x| x.text() == test_file_name)); Ok(()) } #[rstest] fn uploading_files_is_prevented(server: TestServer) -> Result<(), Error> { let test_file_name = "uploaded test file.txt"; // Before uploading, check whether the uploaded file does not yet exist. let body = reqwest::blocking::get(server.url())?.error_for_status()?; let parsed = Document::from_read(body)?; assert!(parsed.find(Text).all(|x| x.text() != test_file_name)); // Ensure the file upload form is not present assert!(parsed.find(Attr("id", "file_submit")).next().is_none()); // Then try to upload anyway let form = multipart::Form::new(); let part = multipart::Part::text("this should not be uploaded") .file_name(test_file_name) .mime_str("text/plain")?; let form = form.part("file_to_upload", part); let client = Client::new(); // Ensure uploading fails and returns an error assert!(client .post(server.url().join("/upload?path=/")?) .multipart(form) .send()? .error_for_status() .is_err()); // After uploading, check whether the uploaded file is now getting listed. let body = reqwest::blocking::get(server.url())?; let parsed = Document::from_read(body)?; assert!(!parsed.find(Text).any(|x| x.text() == test_file_name)); Ok(()) } #[rstest] #[case("foo", "bar", "foo/bar")] #[case("/../foo", "bar", "foo/bar")] #[case("/foo", "/../bar", "foo/bar")] #[case("C:/foo", "C:/bar", if cfg!(windows) { "foo/bar" } else { "C:/foo/C:/bar" })] #[case(r"C:\foo", r"C:\bar", if cfg!(windows) { "foo/bar" } else { r"C:\foo/C:\bar" })] #[case(r"\foo", r"\..\bar", if cfg!(windows) { "foo/bar" } else { r"\foo/\..\bar" })] fn path_traversal( #[with(&["-u"])] server: TestServer, #[case] path: &str, #[case] filename: &'static str, #[case] expected: &str, ) -> Result<(), Error> { // create test directories use std::fs::create_dir_all; create_dir_all(server.path().join("foo")).unwrap(); if !cfg!(windows) { for dir in &["C:/foo/C:", r"C:\foo", r"\foo"] { create_dir_all(server.path().join(dir)).expect(&format!("failed to create: {:?}", dir)); } } let expected_path = server.path().join(expected); assert!(!expected_path.exists()); // Perform the actual upload. let part = multipart::Part::text("this should be uploaded") .file_name(filename) .mime_str("text/plain")?; let form = multipart::Form::new().part("file_to_upload", part); Client::new() .post(server.url().join(&format!("/upload?path={}", path))?) .multipart(form) .send()? .error_for_status()?; // Make sure that the file was uploaded to the expected path assert!(expected_path.exists()); Ok(()) } #[rstest] #[case(server(&["-u"]), true)] #[case(server_no_stderr(&["-u", "--no-symlinks"]), false)] fn symlink(#[case] server: TestServer, #[case] ok: bool, tmpdir: TempDir) -> Result<(), Error> { #[cfg(unix)] use std::os::unix::fs::symlink as symlink_dir; #[cfg(windows)] use std::os::windows::fs::symlink_dir; // create symlink directory "foo" to point outside the root let (dir, filename) = ("foo", "bar"); symlink_dir(tmpdir.path(), server.path().join(dir)).unwrap(); let full_path = server.path().join(dir).join(filename); assert!(!full_path.exists()); // try to upload let part = multipart::Part::text("this should be uploaded") .file_name(filename) .mime_str("text/plain")?; let form = multipart::Form::new().part("file_to_upload", part); let status = Client::new() .post(server.url().join(&format!("/upload?path={}", dir))?) .multipart(form) .send()? .error_for_status(); // Make sure upload behave as expected assert_eq!(status.is_ok(), ok); assert_eq!(full_path.exists(), ok); Ok(()) }